Claude Opus 5.5 · Balanced

add-caching-support-for-identityproviderstorageprovider-getforlogin-operations-keycloak

Keycloak · Java · M · 100–299 lines · 3 files

The normal review, with one generalist agent. Judge: Claude Haiku 5.5.

Gold bugs found
1 of 2
Comments published
1
Comments matching a bug
1
Comments not matching
0
Cost of this PR
$0.551

Published comments (1)

mediumbugtestsuite/integration-arquillian/tests/base/src/test/java/org/keycloak/testsuite/organization/cache/OrganizationCacheTest.java:381

IDP cleanup removes literal "alias" so test IDPs are never deleted — The 21 IDPs this test creates leak into later tests in the realm and can break their counts or cache assertions. Register each cleanup with `"idp-alias-" + i`, and change the other `"alias"` cleanup literal in this test to `idp-alias-20`.

Gold bugs found (1)

lowThe test registers cleanup for the literal alias "alias" instead of the created IDP aliases, so the created identity providers are never cleaned up.

Gold bugs missed (1)

highAdding the organization/BROKER_PUBLIC check to the shared LoginFilter.getLoginPredicate also changes IdentityProviderBean.federatedProviderPredicate, so with organizations disabled a user's linked IdP that has an organizationId but is not public is no longer shown on the login page.