Claude Opus 5.5 · Balanced
add-guest-management-functionality-to-existing-bookings-cal-com
cal.com · TypeScript · M · 100–299 lines · 6 files
The normal review, with one generalist agent. Judge: Claude Haiku 5.5.
- Gold bugs found
- 4 of 8
- Comments published
- 5
- Comments matching a bug
- 4
- Comments not matching
- 1
- Cost of this PR
- $0.931
Published comments (5)
Team admins who are not owners are wrongly denied adding guests — `isTeamAdmin` already returns true for both ADMIN and OWNER roles, so also requiring `isTeamOwner` with `&&` gives FORBIDDEN to admins who aren't owners. Use `||`, or call `isTeamAdmin` on its own.
Blacklisted guest emails bypass filter via case differences — A blacklisted address typed in another case, like `Bad@X.com`, still receives booking emails because `BLACKLISTED_GUEST_EMAILS` entries are lowercased but `guest` is not. Lowercase `guest` before both the blacklist check and the attendee-duplicate check.
Calendar update uses the requester's credentials instead of the organizer's — When an attendee or team admin adds guests, the external calendar event is never updated, or the update throws, because `getUsersCredentials(ctx.user)` lacks access to the organizer's calendar. Build `EventManager` from `booking.user.credentials` instead.
sendAddGuestsEmails receives unfiltered guests, so existing attendees get new invites — Existing attendees included in the request get a full 'scheduled' invite instead of the 'guests added' notice. Pass `uniqueGuests` to `sendAddGuestsEmails` instead of the raw `guests` input.
Unbounded `guests` array allows mass email spam via addGuests — Any booking attendee can submit thousands of addresses, making the server create attendee rows and email each one, which turns the mail sender into a spam tool. Add a `.max()` limit to the `guests` array.