Claude Opus 5.5 · Balanced

feat-convert-insightsbookingservice-to-use-prisma-sql-raw-queries-cal-com

cal.com · TypeScript · M · 100–299 lines · 1 files

The normal review, with one generalist agent. Judge: Claude Haiku 5.5.

Gold bugs found
1 of 3
Comments published
1
Comments matching a bug
1
Comments not matching
0
Cost of this PR
$0.388

Published comments (1)

mediumbugpackages/lib/server/service/insightsBooking.ts:72-80

Unparenthesized auth OR condition from getBaseConditions leaks scope when combined — When a caller appends a predicate like `AND "createdAt" > ...`, it binds only to the last OR branch of `authConditions`, returning rows outside the org/team scope. Have `getBaseConditions` wrap every returned fragment in parentheses so callers can combine it safely.

Gold bugs found (1)

highClaims getBaseConditions returns OR fragments without parentheses, so a caller appending `AND <extra>` would leak rows outside the authorization scope.

Gold bugs missed (2)

mediumThe getBaseConditions test uses a single booking matching both auth and filter conditions, so it would pass even if the conditions were not combined.
mediumThe new public options type makes teamId optional for team scope, so a missing teamId compiles and silently yields empty insights instead of a type error.