Claude Opus 5.5 · Heavy

add-html-sanitizer-for-translated-message-resources-keycloak

Keycloak · Java · M · 100–299 lines · 6 files

The generalist plus 9 specialist lens agents in parallel, then the same verify and dedup steps. Judge: Claude Haiku 5.5.

Gold bugs found
2 of 2
Comments published
3
Comments matching a bug
2
Comments not matching
1
Cost of this PR
$6.915

Published comments (3)

mediumbugjs/apps/admin-ui/maven-resources/theme/keycloak.v2/admin/messages/messages_en.properties:3138

i18next can't fill single-brace and MessageFormat choice placeholders — Both admin-ui and account-ui `i18n.ts` keep i18next's default `{{ }}` interpolation, so `{0}`/`{1}`/`{2}` stay unfilled and `{2,choice,...}` shows up as literal text. Unless the server formats this message, keep the `{{n}}` placeholders here and in account-ui `messages_en.properties`. **Also found in:** - `js/apps/account-ui/maven-resources/theme/keycloak.v3/account/messages/messages_en.properties:188-188`

mediumbugthemes/src/main/resources-community/theme/base/account/messages/messages_lt.properties:101

Lithuanian totpStep1 replaced with Italian text — Lithuanian users will see Italian text here, and the same Italian text also landed in `loginTotpStep1` in the Lithuanian login messages. Replace both with Lithuanian, roughly "Įdiekite vieną iš šių programėlių savo mobiliajame telefone:". **Also found in:** - `themes/src/main/resources-community/theme/base/login/messages/messages_lt.properties:71-71`

mediumbugmisc/theme-verifier/src/main/java/org/keycloak/themeverifier/VerifyMessageProperties.java:106-111

Suffix scan overlaps common prefix, causing StringIndexOutOfBoundsException — When `start + end` exceeds the shorter string's length, `substring(start, length - end)` gets an end below its begin. For example, `<b>x</b></b>` sanitized to `<b>x</b>` gives start=8, end=4.

Gold bugs found (2)

mediumThe diff-trimming code computes common prefix and suffix independently, so they can overlap and substring throws StringIndexOutOfBoundsException, crashing the verifier instead of reporting the illegal HTML.
mediumThe account and admin UI bundles now use Java MessageFormat placeholders and choice syntax for error-invalid-multivalued-size, but i18next expects {{n}}, so the UI shows literal {0}/{1}/{2} and the raw choice text.

Gold bugs missed (0)

None.