Claude Opus 5.5 · Heavy
feature-automatically-downsize-large-images-discourse-cursor
Discourse · Ruby · S · 30–99 lines · 3 files
The generalist plus 9 specialist lens agents in parallel, then the same verify and dedup steps. Judge: Claude Haiku 5.5.
- Gold bugs found
- 3 of 8
- Comments published
- 5
- Comments matching a bug
- 3
- Comments not matching
- 2
- Cost of this PR
- $1.680
Published comments (5)
Hardcoded 10MB upload limit ignores configured max_<type>_size_kb settings — Sites whose `max_<type>_size_kb` exceeds 10MB now have valid uploads rejected in the browser, while attachments between the setting and 10MB upload in full only to fail on the server. Use the larger of 10MB and the setting for images, and `Discourse.SiteSettings['max_' + type + '_size_kb']` as-is for attachments.
Animated GIF downsize passes "80%" to gifsicle --resize-fit, which needs WxH — Animated GIFs go to `resize_instructions_animated` in `optimized_image.rb`, which builds `gifsicle --resize-fit 80%`, but `--resize-fit` only accepts WxH, so the command fails and every attempt is wasted. Pass explicit WxH `dimensions` computed from the image size, or use gifsicle's `--scale 0.8` on the animated path.
Second `downsize` definition overrides the width/height variant — Ruby has no overloading, so this replaces the width/height form, and the 5-argument `OptimizedImage.downsize` call in `app/jobs/regular/resize_emoji.rb` now raises `ArgumentError`, breaking emoji resizing. Rename the dimensions-string variant or have `ResizeEmoji` pass `"100x100"`.
Upload request runs up to 5 synchronous image downsizes in a row — Up to 5 `convert` and ImageOptim passes on a 10MB file tie up a web worker for seconds, so a few large uploads can exhaust the CPU and worker pool. Pick one scale from the size ratio and call `OptimizedImage.downsize` once, or move downsizing to a background job.
Attachment size limit hardcoded to 10 MB instead of the server's site setting — The server still caps attachments at `SiteSetting.max_attachment_size_kb`, so the `file_too_large` alert advertises a 10240 KB limit the server will reject. Keep reading `Discourse.SiteSettings['max_' + type + '_size_kb']` for non-image types so the shown limit matches the enforced one.