Claude Sonnet 5.5 · Balanced

add-client-resource-type-and-scopes-to-authorization-schema-keycloak

Keycloak · Java · L · 300–799 lines · 5 files

The normal review, with one generalist agent. Judge: Claude Haiku 5.5.

Gold bugs found
2 of 8
Comments published
2
Comments matching a bug
2
Comments not matching
0
Cost of this PR
$1.495

Published comments (2)

highbugservices/src/main/java/org/keycloak/services/resources/admin/permissions/ClientPermissionsV2.java:147-150

canExchangeTo throws UnsupportedOperationException, crashing token exchange in V2 — With V2 enabled, `MgmtPermissionsV2.clients()` returns this class, so `AbstractTokenExchangeProvider` hits an uncaught `UnsupportedOperationException` on every cross-audience exchange. Return `false` instead so the caller produces the normal 403 response.

mediumbugservices/src/main/java/org/keycloak/services/resources/admin/permissions/ClientPermissionsV2.java:138-142

getClientsWithPermission may miss per-client resources and include the type resource — Per-client resources made by `AdminPermissionsSchema.getOrCreateResource` have no type, so `resourceStore.findByType` likely skips them, and `AvailableRoleMappingResource` loses those clients. Iterate per-client resources by name or owner, or set the type there, and skip the "Clients" type resource.

Gold bugs found (2)

highgetClientsWithPermission in ClientPermissionsV2 only finds the type-level 'Clients' resource and returns its name, never actual client ids, so callers that resolve the returned values as client ids get wrong results or null clients.
highClientPermissionsV2.canExchangeTo throws UnsupportedOperationException, but AbstractTokenExchangeProvider still calls clients().canExchangeTo for client-to-client exchange, so with token exchange and FGAP V2 enabled the request fails with a server error instead of a permission decision.

Gold bugs missed (6)

mediumClaims the removal-cleanup listener is guarded by the V1 fine-grained flag, so client/role/group permissions are orphaned when V1 is disabled or only V2 is enabled.
mediumClaims getResourceTypeResource can return null in ClientPermissionsV2.hasPermission, causing a NullPointerException in findByResource.
mediumClientPermissionsV2.canView() ignores a global MANAGE permission, so admins with only global manage take the unpaginated, per-client evaluated listing path.
highcanView(client) short-circuits on the global all-clients VIEW permission, so a client-specific permission denying an admin is never evaluated and the client is still viewable.
mediumThe negative check for removing a default client scope expects ForbiddenException, but it can come from the preceding getDefaultClientScopes() call, so the test passes even without a permission check on removal.
highIn ClientPermissionsV2.hasPermission, an admin granted a permission on all clients is denied on any client that also has its own per-client permission resource, because only the per-client resource is evaluated.