Claude Sonnet 5.5 · Balanced
dual-storage-architecture-grafana-codex
Grafana · Go · L · 300–799 lines · 4 files
The normal review, with one generalist agent. Judge: Claude Haiku 5.5.
- Gold bugs found
- 4 of 9
- Comments published
- 4
- Comments matching a bug
- 4
- Comments not matching
- 0
- Cost of this PR
- $0.548
Published comments (4)
Async legacy create write uses request context that is cancelled on return — The request `ctx` is cancelled once the handler returns, so the background write can abort mid-flight and leave the legacy store out of sync. Derive the timeout from `context.WithoutCancel(ctx)`, and apply the same fix in the `Update`, `Delete` and `DeleteCollection` goroutines.
Delete success metric uses object name as label, causing unbounded cardinality — Using `name` as a label value creates one metric series per deleted object, which means unbounded cardinality and metrics inconsistent with other calls. Pass `options.Kind` instead, and use the enriched `log` rather than `d.Log` when setting the context logger.
Async legacy update uses raw objInfo instead of the object Storage persisted — Passing the raw `objInfo` lets `Legacy.Update` recompute the change against its own old copy after the request ends, so legacy can store different content than Storage. Wrap the result as `updateWrapper{upstream: objInfo, updated: res}` before the goroutine and pass that to `Legacy.Update`.
Failed storage Create recorded as legacy duration instead of storage duration — Recording a failed Storage create with `recordLegacyDuration` pollutes the legacy metrics and leaves the storage error metric empty. Call `recordStorageDuration(true, ...)` instead. **Also found in:** - `pkg/apiserver/rest/dualwriter_mode3.go:127-131` - `pkg/apiserver/rest/dualwriter_mode3.go:161-167`