Claude Sonnet 5.5 · Balanced

feature-localization-fallbacks-server-side-discourse-cursor

Discourse · Ruby · S · 30–99 lines · 6 files

The normal review, with one generalist agent. Judge: Claude Haiku 5.5.

Gold bugs found
1 of 2
Comments published
1
Comments matching a bug
1
Comments not matching
0
Cost of this PR
$0.133

Published comments (1)

mediumbugconfig/initializers/i18n.rb:20-22

Fallback locales only loaded from controller, not jobs, mailers or with_locale — Because only `ApplicationController#set_locale` calls `ensure_loaded!`, jobs, mailers, and `I18n.with_locale` blocks like `PostDestroyer` never load fallback files and silently fail to fall back. Load every locale in `I18n.fallbacks[config.locale]` inside `I18n.translate`/`load_locale` instead.

Gold bugs found (1)

mediumFallback locale catalogs are only loaded in the controller's set_locale filter, while translate loads just the current locale, so translations outside requests (jobs, mailers) cannot fall back to the site default or English.

Gold bugs missed (1)

mediumThe translation cache key does not include the site or its default locale, but fallback results now depend on SiteSetting.default_locale, so multisite processes or a changed default locale serve stale fallback translations.