Claude Sonnet 5.5 · Balanced

implement-access-token-context-encoding-framework-keycloak

Keycloak · Java · L · 300–799 lines · 6 files

The normal review, with one generalist agent. Judge: Claude Haiku 5.5.

Gold bugs found
0 of 0
Comments published
2
Comments matching a bug
0
Comments not matching
2
Cost of this PR
$0.922

Published comments (2)

mediumbugtestsuite/integration-arquillian/tests/base/src/test/java/org/keycloak/testsuite/AssertEvents.java:482-483

isAccessTokenId matcher checks wrong substring and inverts grant comparison — The matcher accepts any `xxxxxx:uuid`-shaped value and never validates the grant type, so tests using it can pass wrongly. Read the shortcut with `substring(4, 6)` and return false when it differs from `expectedGrantShortcut`, also checking the length is 6.

mediumbugservices/src/main/java/org/keycloak/protocol/oidc/encode/AccessTokenContext.java:73

rawTokenId null check validates grantType instead of rawTokenId — A null `rawTokenId` passes validation and yields ids like `onrtac:null` from `encodeTokenId` instead of failing fast. Call `Objects.requireNonNull` on `rawTokenId` rather than `grantType`.

Gold bugs found (0)

None.

Gold bugs missed (0)

None.