Claude Sonnet 5.5 · Heavy
feat-convert-insightsbookingservice-to-use-prisma-sql-raw-queries-cal-com
cal.com · TypeScript · M · 100–299 lines · 1 files
The generalist plus 9 specialist lens agents in parallel, then the same verify and dedup steps. Judge: Claude Haiku 5.5.
- Gold bugs found
- 1 of 3
- Comments published
- 1
- Comments matching a bug
- 1
- Comments not matching
- 0
- Cost of this PR
- $0.955
Published comments (1)
mediumbugpackages/lib/server/service/__tests__/insightsBooking.integration-test.ts:477-491
getBaseConditions test seeds one booking, so it can't detect dropped conditions — With only one booking matching both conditions, the test still passes if `getBaseConditions` drops a condition or returns an always-true one. Seed a booking matching only the auth condition and another matching only the filter condition, then assert both are excluded from the results.
Gold bugs found (1)
mediumThe getBaseConditions test uses a single booking matching both auth and filter conditions, so it would pass even if the conditions were not combined.
Gold bugs missed (2)
mediumThe new public options type makes teamId optional for team scope, so a missing teamId compiles and silently yields empty insights instead of a type error.
highClaims getBaseConditions returns OR fragments without parentheses, so a caller appending `AND <extra>` would leak rows outside the authorization scope.