Gemini 3.8 Flash · Balanced

add-html-sanitizer-for-translated-message-resources-keycloak

Keycloak · Java · M · 100–299 lines · 6 files

The normal review, with one generalist agent. Judge: Claude Haiku 5.5.

Gold bugs found
1 of 2
Comments published
1
Comments matching a bug
1
Comments not matching
0
Cost of this PR
$0.657

Published comments (1)

highbugmisc/theme-verifier/src/main/java/org/keycloak/themeverifier/VerifyMessageProperties.java:106-111

Overlapping prefix and suffix cause StringIndexOutOfBoundsException — When `start + end` exceeds the string length, calling `substring` crashes theme verification. Bound `end` in the `while` loop condition using `sanitized.length() - start` and `value.length() - start`.

Gold bugs found (1)

mediumThe diff-trimming code computes common prefix and suffix independently, so they can overlap and substring throws StringIndexOutOfBoundsException, crashing the verifier instead of reporting the illegal HTML.

Gold bugs missed (1)

mediumThe account and admin UI bundles now use Java MessageFormat placeholders and choice syntax for error-invalid-multivalued-size, but i18next expects {{n}}, so the UI shows literal {0}/{1}/{2} and the raw choice text.