Gemini 3.8 Flash · Heavy

enhance-embed-url-handling-and-validation-system-discourse-cursor

Discourse · Ruby · M · 100–299 lines · 6 files

The generalist plus 9 specialist lens agents in parallel, then the same verify and dedup steps. Judge: Claude Haiku 5.5.

Gold bugs found
2 of 12
Comments published
5
Comments matching a bug
2
Comments not matching
3
Cost of this PR
$0.814

Published comments (5)

highbugapp/jobs/scheduled/poll_feed.rb:35

NoMethodError when feed item content is nil — Feed items that omit content abort the scheduled poll job when `scrub` is called on `nil`. Check that `i.content` is present before calling `scrub` and `CGI.unescapeHTML`.

highbugapp/views/embed/best.html.erb:6

Syntax error from invalid `<%- end if %>` tag — ERB compilation fails and crashes the view whenever comments render. Replace `<%- end if %>` with `<%- end %>` to close the conditional block.

mediumbugspec/jobs/poll_feed_spec.rb:19-23

Test 'requires feed_polling_url' does not enable feed polling — Because `SiteSetting.feed_polling_enabled?` defaults to `false`, `execute` short-circuits early and creates a false positive even if URL validation breaks. Stub `feed_polling_enabled?` to `true` and supply `embed_by_username`.

mediumbugspec/jobs/poll_feed_spec.rb:25-29

Test does not stub feed_polling_enabled? or feed_polling_url — Because `SiteSetting.feed_polling_enabled?` defaults to `false`, `execute` short-circuits early and passes even if username checks break. Stub `feed_polling_enabled?` to `true` and configure `feed_polling_url`.

mediumbugapp/views/layouts/embed.html.erb:10-12

Full URL passed as postMessage targetOrigin fails origin match — Passing the full URL from `request.referer` fails origin matching or throws a `SyntaxError`, blocking `discourse-resize` messages. Pass `'*'` or a parsed origin to `parent.postMessage` instead.

Gold bugs found (2)

highPollFeed reads i.content.scrub for every feed item, so items without a content element (common in RSS feeds that only have description) raise NoMethodError and abort the import of the remaining items.
mediumThe 'requires feed_polling_url' and 'requires embed_by_username' specs leave feed_polling_enabled at its false default, so they never reach the condition they name and would pass with those checks deleted.

Gold bugs missed (10)

highThe referer and embed_url host checks compare against SiteSetting.embeddable_host case-sensitively, so a host differing only in case is rejected even though hostnames are case-insensitive.
criticalTopicEmbed.import appends a footer that interpolates the URL unescaped into an <a href='...'> tag in raw HTML that is later rendered unsanitized, so a crafted URL can inject markup; it also appends to contents with << without handling nil.
highWhen the embedded post has been deleted, TopicEmbed.import's update path passes a nil embed.post to PostRevisor and crashes on every later import of that URL.
mediumClaims import_remote crashes on unparseable pages (nil content) and dead URLs because it does no nil check or network error handling around open(url).read.
mediumabsolutize_urls only handles root-relative paths: protocol-relative URLs like //cdn.example.com/x.png are rewritten to http://host/cdn.example.com/x.png and path-relative links are left unresolved, breaking links and images in imported posts.
mediumEvery retrieval of an article not yet embedded synchronously polls and imports the entire RSS feed, and since throttling is per URL, many different article requests repeat the full feed download and processing.
high`import_remote` fetches the embed URL with open-uri, which follows redirects, so the embeddable-host check on the initial URL can be bypassed to reach internal services (SSRF).
mediumThe retrieve throttle is keyed by the full embed URL, so an anonymous client can vary the query string on the embeddable host to bypass it and make the server create an unbounded number of topics.
mediumThe "requires feed_polling_enabled?" spec leaves feed_polling_url and embed_by_username at their blank defaults, so poll_feed is skipped regardless and the test would pass even without the enabled check.
highThe embed layout references the 'embed' stylesheet and embed.js, but neither is in config.assets.precompile, so with precompiled assets in production the embed page fails to load them.