GLM-5.3 · Balanced
add-caching-support-for-identityproviderstorageprovider-getforlogin-operations-keycloak
Keycloak · Java · M · 100–299 lines · 3 files
The normal review, with one generalist agent. Judge: Claude Haiku 5.5.
- Gold bugs found
- 0 of 2
- Comments published
- 1
- Comments matching a bug
- 0
- Comments not matching
- 1
- Cost of this PR
- $1.190
Published comments (1)
highbugserver-spi/src/main/java/org/keycloak/models/IdentityProviderStorageProvider.java:252-255
getLoginPredicate() NPEs when IDP config is null — Because `IdentityProviderModel.getConfig()` can return null for IDPs created or updated via the admin API, operations that previously succeeded now throw NPEs in `InfinispanIdentityProviderStorageProvider.create/update`, returning 500 errors. Null-check `getConfig()` before reading `OrganizationModel.BROKER_PUBLIC`.
Gold bugs found (0)
None.
Gold bugs missed (2)
lowThe test registers cleanup for the literal alias "alias" instead of the created IDP aliases, so the created identity providers are never cleaned up.
highAdding the organization/BROKER_PUBLIC check to the shared LoginFilter.getLoginPredicate also changes IdentityProviderBean.federatedProviderPredicate, so with organizations disabled a user's linked IdP that has an organizationId but is not public is no longer shown on the login page.