GLM-5.3 · Balanced

feature-automatically-downsize-large-images-discourse-cursor

Discourse · Ruby · S · 30–99 lines · 3 files

The normal review, with one generalist agent. Judge: Claude Haiku 5.5.

Gold bugs found
3 of 8
Comments published
4
Comments matching a bug
3
Comments not matching
1
Cost of this PR
$0.801

Published comments (4)

highbugapp/controllers/uploads_controller.rb:63-70

Downsizing loses GIF animation because tempfile path lacks .gif extension — Animated GIFs are silently flattened to one frame: `OptimizedImage#optimize` detects animation only when the source path matches `/\.GIF$/i`, which the extensionless multipart tempfile never does, so `allow_animation` is ignored. Downsize from a tempfile carrying the original extension, as `OptimizedImage.create_for` does, or match on the original filename.

highbugapp/assets/javascripts/discourse/lib/utilities.js:180-185

Hardcoded 10MB limit drops per-type site setting checks in client validation — Attachments above `max_attachment_size_kb` now pass client-side and fail only after a full upload, and sites configured above 10MB reject valid files, because `maxSizeKB` drops the per-type setting lookup. Restore the settings-driven limit for attachments, keeping the 10MB cap for images only; the 413 handler repeats this hardcode.

highbugapp/models/optimized_image.rb:149-151

Duplicate downsize definition shadows 5-arg version, breaking ResizeEmoji — Every custom-emoji upload now fails its `Jobs::ResizeEmoji` job with `ArgumentError` (5 for 4), leaving the emoji un-downsized: the second `downsize` definition takes only 4 parameters and shadows the original. Keep one signature accepting both the width/height form and the dimensions string.

mediumsecurityapp/controllers/uploads_controller.rb:63-70

Unvalidated downsize loop exposes ImageMagick to decompression bombs and banned types — Any logged-in user can force up to five full ImageMagick decode/re-encode passes on a 10MB file with huge pixel dimensions, since the downsize loop runs before size and `authorized_extensions` validation and gates only on `FileHelper.is_image?(filename)`. Downsize only after those checks pass, and cap accepted pixel area first.

Gold bugs found (3)

highdownsize is defined twice in OptimizedImage; the new (from, to, dimensions, opts) version overrides the (max_width, max_height) one, so existing callers such as ResizeEmoji that pass width and height now raise ArgumentError.
highThe client-side upload size check hardcodes 10 MB instead of the per-type max_<type>_size_kb setting, so attachment limits diverge from the server: larger allowed attachments are blocked and smaller limits are only enforced server-side.
mediumAuto-downsizing passes the upload tempfile path, which lacks a .gif extension, so the animated branch is never chosen and convert keeps only the first frame, flattening oversized animated GIFs.

Gold bugs missed (5)

highThe upload downsizing passes a percentage ('80%') as dimensions, but for animated GIFs the gifsicle path uses --resize-fit, which expects WxH geometry, so downsizing silently fails.
highClaims the downsize loop checking tempfile.size may never terminate because of a stale cached size, causing infinite loops.
highOversized SVG uploads go through the new ImageMagick downsize loop because SVG counts as an image, so the vector file is rasterized or corrupted in place before Upload.create_for parses it as SVG.
criticalThe upload tempfile path, which for API URL uploads embeds the request-controlled type param, is now passed to OptimizedImage.downsize and run unescaped in a shell via backticks, allowing command injection through type.
mediumThe 413 upload error message states a hard-coded 10 MB maximum that may not match the limit the server or web server actually enforces.