GLM-5.3 · Heavy
optimize-header-layout-performance-with-flexbox-mixins-discourse-cursor
Discourse · Ruby · S · 30–99 lines · 5 files
The generalist plus 9 specialist lens agents in parallel, then the same verify and dedup steps. Judge: Claude Haiku 5.5.
- Gold bugs found
- 0 of 5
- Comments published
- 1
- Comments matching a bug
- 0
- Comments not matching
- 1
- Cost of this PR
- $1.380
Published comments (1)
mediumbugapp/assets/stylesheets/common/base/header.scss:35-40
.panel lost float: right, breaking header layout in non-flexbox browsers (IE9) — In IE9 (supported via `ie9-hax.js.es6`), `.contents` never becomes a flex container, so `margin-left: auto` and `@include order(3)` are inert and the panel stacks below the logo, overlapping `#main-outlet`. Restore `float: right` on `.panel` — floats on flex items are ignored, so flex-capable browsers are unaffected.
Gold bugs found (0)
None.
Gold bugs missed (5)
mediumThe flex-item styles target the inner .extra-info-wrapper instead of the component's root div, so in the flexbox header a long topic title keeps its full width and pushes the navigation panel out instead of being truncated.
lowThe align-items mixin emits no -moz-box-align, so on old Firefox versions using the display:-moz-box fallback the advertised vertical centering is not applied.
lowRemoving the float-based right alignment of .d-header .panel leaves the server-rendered (no-JS) header's login panel, which sits inside .row and is not a flex item, no longer right-aligned next to the title.
lowMaking .small-action a flex container leaves .small-action-desc content-sized (no flex:1), so the right-floated edit/delete buttons inside it sit right after short action descriptions instead of at the right edge of the row.
mediumOn mobile the .small-action custom message keeps margin-left:-40px, tuned for the old 4em left padding; with the new flex layout and 1.5% padding it is pulled into the avatar column and overlaps the icon.