GLM-5.3 · Heavy
replays-self-serve-bulk-delete-system-sentry
Sentry · Python · M · 100–299 lines · 3 files
The generalist plus 9 specialist lens agents in parallel, then the same verify and dedup steps. Judge: Claude Haiku 5.5.
- Gold bugs found
- 4 of 10
- Comments published
- 6
- Comments matching a bug
- 4
- Comments not matching
- 2
- Cost of this PR
- $5.724
Published comments (6)
Feature flag branch renders TableWidgetVisualization with hardcoded empty data — With the `use-table-widget-visualization` flag on, every dashboard table widget renders blank because the branch passes hardcoded empty `columns` and `tableData`, ignoring computed values like `result.data` and `result.meta`. Pass real data — columns from `fields`, `tableData` from the query results — so the flag can be enabled safely.
Unconditional Snuba replay-instance query wastes an RPC when error context is disabled — Every request with error context disabled still pays a wasted `query_replay_instance` RPC plus `process_raw_response` work, since their only consumer `error_ids` is discarded. Evaluate `disable_error_fetching` before querying and skip both calls when it is set.
Null max_segment_id fixture change is neutralized by mocked delete_matched_rows — Because `delete_matched_rows` is patched out, `_make_recording_filenames` never runs, so the null `max_segment_id` fixture verifies nothing — the test passes whether the None-guard is correct, removed, or inverted. Add a test calling `_make_recording_filenames` with a null `max_segment_id` that asserts no recording filenames are produced.
test_basic drops application/reports+json content type, so custom parser is never tested — With `application/reports+json` dropped, every request uses the default `JSONParser`, so `BrowserReportsJSONParser` is never exercised — the suite would pass even if the parser broke. Keep at least one test, like `test_basic`, posting with that content type.
get_multi result zipped positionally with error_ids, mispairing error data — `zip(error_ids, events.values())` assumes `get_multi` returns values in input order, but it returns a dict with no ordering contract, so `id`, title, and message can be mispaired and the `None` filter silently shifts alignment. Look up each node by its generated `node_id` instead.
Mutual-exclusion validators miss falsy zero values for age and timestamp — A report with both `timestamp` and `age` set to 0 slips past the truthiness checks in `validate_timestamp` and `validate_age`, even though zero is a legitimate value for both. Use explicit presence checks like `self.initial_data.get("age") is not None`.