GPT-6 Luna · Balanced
feature-automatically-downsize-large-images-discourse-cursor
Discourse · Ruby · S · 30–99 lines · 3 files
The normal review, with one generalist agent. Judge: Claude Haiku 5.5.
- Gold bugs found
- 2 of 8
- Comments published
- 3
- Comments matching a bug
- 2
- Comments not matching
- 1
- Cost of this PR
- $0.017
Published comments (3)
downsize's geometry overload breaks width/height callers — `ResizeEmoji` still passes width, height, and options, which raises an argument-count error because Ruby replaces the earlier `downsize` definition. Keep one `downsize` method that accepts both call forms, or update all callers to use a geometry string.
Image downsize geometry does not constrain both dimensions — The generated `80%>` geometry does not bound both dimensions, so images may remain above the upload-size limit. Pass explicit dimensions or use a supported percentage geometry that constrains both axes.
Oversized images trigger repeated identical conversions — Repeated synchronous ImageMagick conversions consume CPU and delay uploads, even when each conversion leaves the target unchanged. Derive a target that converges in one bounded conversion, or avoid retrying with the same target.