GPT-6.1 Sol · Balanced
add-client-resource-type-and-scopes-to-authorization-schema-keycloak
Keycloak · Java · L · 300–799 lines · 5 files
The normal review, with one generalist agent. Judge: Claude Haiku 5.5.
- Gold bugs found
- 1 of 8
- Comments published
- 2
- Comments matching a bug
- 1
- Comments not matching
- 1
- Cost of this PR
- $1.468
Published comments (2)
Global client view grants bypass client-specific permission denials — An all-clients `view` grant overrides client-specific denials through `canView(client)` and bypasses object checks in `ClientsResource.getClients()`. Separate global role-based access from policy-based grants, and evaluate object-specific permissions before accepting the all-clients fallback.
Global manage permission fails client-scope listing and viewing guards — Administrators with only all-clients `manage` cannot list client scopes or read realm default scopes, despite authorization by `canManage(ClientScopeModel)` and `canView(ClientScopeModel)`. Update `canView()` so inherited `canListClientScopes()` and `canViewClientScopes()` recognize global `manage` alongside `view`.