GPT-6.1 Sol · Balanced

feature-localization-fallbacks-server-side-discourse-cursor

Discourse · Ruby · S · 30–99 lines · 6 files

The normal review, with one generalist agent. Judge: Claude Haiku 5.5.

Gold bugs found
1 of 2
Comments published
1
Comments matching a bug
1
Comments not matching
0
Cost of this PR
$0.398

Published comments (1)

mediumbugconfig/initializers/i18n.rb:17

Translation cache ignores site-dependent fallback chains — Users can receive stale or another site's fallback language because `translate_accelerator.rb` caches no-argument translations without accounting for `SiteSetting.default_locale`. Include the effective fallback chain in the cache key, or partition and invalidate cached translations when the chain changes.

Gold bugs found (1)

mediumThe translation cache key does not include the site or its default locale, but fallback results now depend on SiteSetting.default_locale, so multisite processes or a changed default locale serve stale fallback translations.

Gold bugs missed (1)

mediumFallback locale catalogs are only loaded in the controller's set_locale filter, while translate loads just the current locale, so translations outside requests (jobs, mailers) cannot fall back to the site default or English.