GPT-6.1 Sol · Balanced

fix-proper-handling-of-group-memberships-discourse-cursor

Discourse · Ruby · L · 300–799 lines · 6 files

The normal review, with one generalist agent. Judge: Claude Haiku 5.5.

Gold bugs found
4 of 10
Comments published
4
Comments matching a bug
4
Comments not matching
0
Cost of this PR
$0.689

Published comments (4)

highbugapp/controllers/groups_controller.rb:22-26

Default member limit truncates the public group membership page — Users cannot reach members beyond the first 50 because the `group-members` route fetches once and its template has no pagination controls. Add pagination to the public page alongside the default `limit` change.

mediumbugapp/assets/javascripts/admin/controllers/admin-group.js.es6:13

Page count adds an empty page when member count is a multiple of the limit — With exactly 50 members and a limit of 50, `totalPages` enables Next to an empty page. Use `Math.ceil(user_count / limit)` and preserve the intended zero-member behavior.

mediumbugapp/controllers/admin/groups_controller.rb:90

Removing membership leaves the user's primary group reference intact — `PostSerializer.primary_group_name` can still identify the user with the removed group because `primary_group_id` remains unchanged. Clear the matching reference when removing membership, preserving the cleanup previously performed by `Group.destroy_deletions`.

mediumbugapp/controllers/admin/groups_controller.rb:71-74

Adding an existing group member violates the unique membership index — Retrying Add or including an existing member in a batch makes `Group.add` violate the unique `(group_id, user_id)` index. Skip existing memberships before insertion, preserving the set-difference behavior of `usernames=`.

Gold bugs found (4)

mediumThe admin group pager computes total pages as floor(user_count / limit) + 1, so when the member count is an exact multiple of the limit it shows an extra page and Next navigates to an empty member list.
highThe public members endpoint now always caps results at 50 per page, but the public group members page has no pagination, so groups with more than 50 members are silently truncated for users.
mediumRemoving a member deletes the membership row directly and skips clearing the user's primary_group_id, so a removed user can keep this group as their primary group.
mediumAdmin add_members pushes every username into group.users without skipping existing members, so adding someone already in the group hits the unique group_users index, returns a 500 and leaves earlier users partially added.

Gold bugs missed (6)

mediumPaging actions fire overlapping member requests and each response unconditionally overwrites offset and members, so a stale response arriving last can revert the list to an earlier page.
mediumCreating a group ignores the alias_level the admin selected, saving only name and visibility, so new groups keep the default alias level.
mediumGroup member pagination is off by one when user_count is a multiple of limit: Next moves to offset == user_count and shows an empty page.
mediumAdmin remove_member deletes memberships with group.users.delete, which skips GroupUser callbacks, so the cached groups.user_count is never decremented and stays inflated.
mediumThe public group members endpoint takes `limit` from params with no upper bound or positivity check, letting a visitor request huge pages or trigger a 500 with a negative limit.
mediumAdmin remove_member calls group.users.delete with a raw integer id, which raises RecordNotFound (404/500) when the user is not or no longer a member, e.g. on concurrent removal.