GPT-6.1 Sol · Balanced

replays-self-serve-bulk-delete-system-sentry

Sentry · Python · M · 100–299 lines · 3 files

The normal review, with one generalist agent. Judge: Claude Haiku 5.5.

Gold bugs found
4 of 10
Comments published
4
Comments matching a bug
4
Comments not matching
0
Cost of this PR
$2.636

Published comments (4)

highbugstatic/app/views/dashboards/widgetCard/chart.tsx:165-173

Table visualization receives empty data and columns instead of query results — Organizations with `use-table-widget-visualization` enabled see an empty table despite populated `tableResults`. Pass the current result’s data and metadata to `TableWidgetVisualization` and derive its columns from the widget fields.

mediumbugstatic/app/views/explore/hooks/useTraceItemAttributeKeys.tsx:39-42

Attribute query cache key omits organization identity — Switching organizations with identical projects and date filters can briefly show the previous organization’s attributes because `useGetTraceItemAttributeKeys` fetches organization-specific data. Include the organization slug in `queryKey` to preserve cache isolation.

mediumbugstatic/app/views/performance/newTraceDetails/traceDrawer/details/span/eapSections/attributes.tsx:65-68

Hidden attributes remain visible when the search is empty — `is_segment`, `project_id`, and `received` remain visible by default because an empty search returns `sorted` before applying `HIDDEN_ATTRIBUTES`. Apply the exclusion before the empty-search return.

mediumbugsrc/sentry/replays/endpoints/project_replay_summarize_breadcrumbs.py:153-155

Mismatched timestamp units place errors out of chronological order — Errors can appear before earlier recording events because `error_events` timestamps use seconds while `event` timestamps use milliseconds. Multiply `error_events[error_idx]["timestamp"]` by 1000 before comparing it with `event.get("timestamp", 0)`.

Gold bugs found (4)

highWith the use-table-widget-visualization flag on, the widget renders TableWidgetVisualization with hardcoded empty columns and data instead of the query results, so every table widget shows an empty table.
mediumThe attribute-keys query key no longer includes the organization slug, so two organizations with the same filters share a cache entry and switching orgs can show the previous org's attribute names.
mediumHIDDEN_ATTRIBUTES is applied only when a search query is present; the no-search early return shows all attributes, so the hidden attributes still appear in the default span attributes view.
mediumError event timestamps (seconds) are compared with replay recording event timestamps (milliseconds), so errors are not interleaved chronologically with breadcrumbs.

Gold bugs missed (6)

mediumThe age/timestamp mutual-exclusion validators check truthiness via initial_data.get(), so a zero value is treated as absent and a report carrying both fields passes validation.
mediumThe validation-failure warning logs the entire raw, attacker-controlled browser report instead of a redacted subset.
mediumThe Snuba replay lookup for error IDs runs even when enable_error_context=false, adding a needless query (and failure point) to opt-out requests.
mediumThe custom cell renderers fall back to default rendering on any falsy return (0, '', null), not only undefined, so a renderer cannot render zero or an empty cell.
mediumEvery paginated breadcrumb-summary request queries the replay and fetches all of its error events from nodestore with no cap, adding latency and memory proportional to the replay's error count on each page.
mediumThe bulk delete test sets max_segment_id to None to cover the new guard in _make_recording_filenames, but it mocks delete_matched_rows, so the guard is never executed and removing it would not fail the test.