GPT-6.1 Sol · Balanced
sms-workflow-reminder-retry-count-tracking-cal-com
cal.com · TypeScript · S · 30–99 lines · 3 files
The normal review, with one generalist agent. Judge: Claude Haiku 5.5.
- Gold bugs found
- 1 of 5
- Comments published
- 1
- Comments matching a bug
- 1
- Comments not matching
- 0
- Cost of this PR
- $0.206
Published comments (1)
highbugpackages/features/ee/workflows/api/scheduleSMSReminders.ts:190-197
Retry bookkeeping failures abort processing of remaining SMS reminders — If cancellation deletes a loaded reminder, `prisma.workflowReminder.update` throws inside `catch`, returning HTTP 500 and skipping remaining reminders. Use `prisma.workflowReminder.updateMany` to tolerate missing rows, and catch bookkeeping failures within the per-reminder error handler.
Gold bugs found (1)
mediumThe retry-count update inside the catch block is not guarded, so if it throws (for example the reminder was deleted concurrently) the error escapes the loop and the cron run fails, skipping the remaining reminders.
Gold bugs missed (4)
mediumretryCount is set to reminder.retryCount + 1 from a value read at the start of the run instead of an atomic increment, so overlapping runs can lose increments.
highThe deleteMany OR clause applies retryCount > 1 without the SMS method filter, so the SMS cron deletes any workflow reminder (email, WhatsApp) with retryCount above 1.
criticalClaims transient errors increment retryCount, so two runs during an outage delete the whole pending SMS reminder queue.
highSMS-sending locks are counted as failed scheduling attempts: scheduleSMS returns undefined for locked users/teams, retryCount is incremented, and after two cron runs the retryCount > 1 cleanup deletes future reminders even if sending is later unlocked.