GPT-6.1 Sol · Heavy

feature-automatically-downsize-large-images-discourse-cursor

Discourse · Ruby · S · 30–99 lines · 3 files

The generalist plus 9 specialist lens agents in parallel, then the same verify and dedup steps. Judge: Claude Haiku 5.5.

Gold bugs found
2 of 8
Comments published
3
Comments matching a bug
2
Comments not matching
1
Cost of this PR
$0.730

Published comments (3)

highbugapp/assets/javascripts/discourse/lib/utilities.js:182

Fixed 10 MB upload limit ignores configured attachment size limits — Attachments permitted by `max_attachment_size_kb` can be rejected, while files exceeding smaller configured limits upload only to fail server-side validation. Apply the relaxed `maxSizeKB` limit only to images and retain `max_attachment_size_kb` for attachments.

highbugapp/models/optimized_image.rb:149-150

Duplicate downsize definition breaks width/height calls — Ruby replaces the earlier `downsize` definition, so width/height calls fail at `opts[:allow_animation]` in `optimize`, and calls with a fifth argument raise an argument-count error. Give the geometry-based method a separate name or make `downsize` explicitly support both argument forms.

mediumbugapp/controllers/uploads_controller.rb:67

Oversized animated avatars use the thumbnail animation setting — Oversized animated avatars are permanently flattened when `allow_animated_avatars` is enabled but `allow_animated_thumbnails` is disabled, before `Upload.create_for` can apply the avatar setting. Pass `SiteSetting.allow_animated_avatars` to `OptimizedImage.downsize` for avatar uploads, matching `Upload.create_for`.

Gold bugs found (2)

highdownsize is defined twice in OptimizedImage; the new (from, to, dimensions, opts) version overrides the (max_width, max_height) one, so existing callers such as ResizeEmoji that pass width and height now raise ArgumentError.
highThe client-side upload size check hardcodes 10 MB instead of the per-type max_<type>_size_kb setting, so attachment limits diverge from the server: larger allowed attachments are blocked and smaller limits are only enforced server-side.

Gold bugs missed (6)

highThe upload downsizing passes a percentage ('80%') as dimensions, but for animated GIFs the gifsicle path uses --resize-fit, which expects WxH geometry, so downsizing silently fails.
mediumAuto-downsizing passes the upload tempfile path, which lacks a .gif extension, so the animated branch is never chosen and convert keeps only the first frame, flattening oversized animated GIFs.
highClaims the downsize loop checking tempfile.size may never terminate because of a stale cached size, causing infinite loops.
highOversized SVG uploads go through the new ImageMagick downsize loop because SVG counts as an image, so the vector file is rasterized or corrupted in place before Upload.create_for parses it as SVG.
criticalThe upload tempfile path, which for API URL uploads embeds the request-controlled type param, is now passed to OptimizedImage.downsize and run unescaped in a shell via backticks, allowing command injection through type.
mediumThe 413 upload error message states a hard-coded 10 MB maximum that may not match the limit the server or web server actually enforces.