GPT-6.1 Sol · Heavy

github-oauth-security-enhancement-sentry

Sentry · Python · M · 100–299 lines · 2 files

The generalist plus 9 specialist lens agents in parallel, then the same verify and dedup steps. Judge: Claude Haiku 5.5.

Gold bugs found
1 of 1
Comments published
5
Comments matching a bug
1
Comments not matching
4
Cost of this PR
$1.283

Published comments (5)

highsecuritysrc/sentry/integrations/github/integration.py:401-408

Predictable OAuth state allows attacker-controlled GitHub account linking — An attacker can link their GitHub account to a victim’s pending setup because `pipeline.signature` is predictable, not session-specific. Generate a cryptographically random OAuth state for each authorization attempt, store it in pipeline state, and validate the callback against that value.

highbugsrc/sentry/integrations/github/integration.py:501-505

Missing sender metadata crashes GitHub reinstallation — Reinstallation can raise `KeyError` because `build_integration` only populates `integration.metadata["sender"]` when setup state includes sender metadata. Check for the missing key and return a controlled error, or obtain authoritative installer information before comparing logins.

mediumbugsrc/sentry/integrations/github/integration.py:132-141

Short error messages lose their translation extraction sites — Translation extraction cannot resolve `error_short` in `_(error_short)`, leaving user-facing errors untranslated in newly generated catalogs. Wrap each short-message literal in `_()` at its definition or call site, including the default and both callers.

mediumbugsrc/sentry/integrations/github/integration.py:423-425

OAuth token request failures bypass installation error handling — A transport or HTTP failure in `safe_urlopen` escapes installation error handling and produces a server error instead of the failure response. Move the token request inside the `try` block and catch the expected outbound-request exceptions.

mediumbugtests/sentry/integrations/github/test_integration.py:392-396

Missing-installation test passes on OAuth state rejection — This test can pass without reaching the installation lookup because `OAuthLoginView` returns the asserted error when `state` is invalid. Use the actual pipeline state and assert the installation-not-found response so broken missing-installation handling fails the test.

Gold bugs found (1)

mediumtest_installation_not_found uses a wrong OAuth state, so it fails at the state check and never reaches the installation-not-found path it is meant to test.

Gold bugs missed (0)

None.