Kimi K3.1 Pro · Balanced
replays-self-serve-bulk-delete-system-sentry
Sentry · Python · M · 100–299 lines · 3 files
The normal review, with one generalist agent. Judge: Claude Haiku 5.5.
- Gold bugs found
- 7 of 10
- Comments published
- 8
- Comments matching a bug
- 7
- Comments not matching
- 1
- Cost of this PR
- $3.778
Published comments (8)
Zero-valued age and timestamp bypass mixed-format validation — Both cross-field validators test the other field with truthiness, so a report containing `age: 0` and `timestamp: 0` passes even though mixed report-format fields are meant to be rejected. Check field membership with `"age" in self.initial_data` and `"timestamp" in self.initial_data` instead of `.get()`.
Serializer accepts reports with neither age nor timestamp — Marking both `age` and `timestamp` optional without object-level validation accepts reports containing neither field, which match neither supported report shape. Add `validate()` to require exactly one of the two fields while preserving the mutual-exclusion checks.
`fetch_error_details` passes the replay's entire unbounded error-ID aggregation to… — Cap or sample the IDs before the multi-get and enforce a prompt-size budget.
When `use-table-widget-visualization` is enabled, the component discards `result.data` and… — Pass the fetched result into `TableWidgetVisualization`, or keep `StyledSimpleTableChart` until that adapter is implemented.
Falsy custom cell values incorrectly trigger default rendering — The truthiness checks here and in `renderDefaultHeadCell` override valid custom `null`, empty-string, zero, or `false` results even though the API specifies fallback only for `undefined`. Use `cell !== undefined` in both renderers so custom blank and zero-valued cells are preserved.
Query key omits organization, causing cross-organization cache reuse — The React Query key omits the organization even though `queryFn` fetches an organization-scoped endpoint, so switching organizations with identical filters can reuse the previous organization's cached attribute keys. Include `organization.slug` or the full endpoint URL in `queryKey`.
Hidden attributes remain visible when the search query is empty — The hidden-attribute predicate runs only during a nonempty search because the empty-search branch returns `sorted` directly, leaving `is_segment`, `project_id`, and `received` visible in the default view. Filter `HIDDEN_ATTRIBUTES` before the empty-search return, then apply the search predicate.
Replay aggregation query runs when error context is disabled — When `enable_error_context=false`, the endpoint still executes the full replay-aggregation Snuba query and processes its response before discarding `error_ids`, adding an unnecessary network query to every disabled-context request. Evaluate the flag before this block and skip replay querying and response processing when error context is disabled.