MiniMax M3 · Balanced

github-oauth-security-enhancement-sentry

Sentry · Python · M · 100–299 lines · 2 files

The normal review, with one generalist agent. Judge: Claude Haiku 5.5.

Gold bugs found
0 of 1
Comments published
1
Comments matching a bug
0
Comments not matching
1
Cost of this PR
$0.156

Published comments (1)

highbugsrc/sentry/integrations/github/integration.py:416-432

OAuthLoginView swallows exceptions only after the network call — `safe_urlopen` in `OAuthLoginView.dispatch` runs outside the `try/except`, so a missing `code` or network errors surface as 500s instead of the friendly page. Move the `try` above `safe_urlopen` to mirror `OAuth2CallbackView.exchange_token` in oauth2.py.

Gold bugs found (0)

None.

Gold bugs missed (1)

mediumtest_installation_not_found uses a wrong OAuth state, so it fails at the state check and never reaches the installation-not-found path it is meant to test.