MiniMax M3 · Heavy

fix-proper-handling-of-group-memberships-discourse-cursor

Discourse · Ruby · L · 300–799 lines · 6 files

The generalist plus 9 specialist lens agents in parallel, then the same verify and dedup steps. Judge: Claude Haiku 5.5.

Gold bugs found
2 of 10
Comments published
3
Comments matching a bug
2
Comments not matching
1
Cost of this PR
$0.309

Published comments (3)

highbugconfig/routes.rb:49-50

Group member PUT/DELETE routes missing :id segment — `delete "members"` and `put "members"` resolve as collection actions, so calls like `Discourse.ajax('/admin/groups/' + id + '/members.json')` miss the route. Add `on: :member` so they generate `/admin/groups/:id/members`. **Also found in:** - `app/controllers/admin/groups_controller.rb:65-96`

mediumbugapp/assets/javascripts/admin/controllers/admin-group.js.es6:11-14

totalPages off-by-one when user_count is a multiple of limit — `totalPages` computes one extra page whenever `user_count` is an exact multiple of `limit`, so `showingLast` stays true on the last real page. Replace `Math.floor(...) + 1` with `Math.ceil(...)` so the count matches reality.

mediumbugapp/assets/javascripts/admin/controllers/admin-group.js.es6:29-49

Race condition between next/previous clicks corrupts displayed model state — Out-of-order responses from `findMembers` overwrite `offset`, `user_count`, and `members` of the faster click, so the rendered page no longer matches `currentPage`. Guard `next`/`previous` against re-entry (e.g. a `loadingMembers` flag) and drop stale responses in `setProperties`. **Also found in:** - `app/assets/javascripts/discourse/models/group.js:20-38`

Gold bugs found (2)

mediumThe admin group pager computes total pages as floor(user_count / limit) + 1, so when the member count is an exact multiple of the limit it shows an extra page and Next navigates to an empty member list.
mediumPaging actions fire overlapping member requests and each response unconditionally overwrites offset and members, so a stale response arriving last can revert the list to an earlier page.

Gold bugs missed (8)

highThe public members endpoint now always caps results at 50 per page, but the public group members page has no pagination, so groups with more than 50 members are silently truncated for users.
mediumCreating a group ignores the alias_level the admin selected, saving only name and visibility, so new groups keep the default alias level.
mediumRemoving a member deletes the membership row directly and skips clearing the user's primary_group_id, so a removed user can keep this group as their primary group.
mediumGroup member pagination is off by one when user_count is a multiple of limit: Next moves to offset == user_count and shows an empty page.
mediumAdmin remove_member deletes memberships with group.users.delete, which skips GroupUser callbacks, so the cached groups.user_count is never decremented and stays inflated.
mediumAdmin add_members pushes every username into group.users without skipping existing members, so adding someone already in the group hits the unique group_users index, returns a 500 and leaves earlier users partially added.
mediumThe public group members endpoint takes `limit` from params with no upper bound or positivity check, letting a visitor request huge pages or trigger a 500 with a negative limit.
mediumAdmin remove_member calls group.users.delete with a raw integer id, which raises RecordNotFound (404/500) when the user is not or no longer a member, e.g. on concurrent removal.