Claude Sonnet 5.5 · Balanced

feature-automatically-downsize-large-images-discourse-cursor

Discourse · Ruby · S · 30–99 lines · 3 files

The normal review, with one generalist agent. Judge: Claude Haiku 5.5.

Gold bugs found
3 of 8
Comments published
3
Comments matching a bug
3
Comments not matching
0
Cost of this PR
$0.241

Published comments (3)

highbugapp/models/optimized_image.rb:145-151

`downsize` is defined twice, so the second definition replaces the first — `Jobs::ResizeEmoji` still calls `OptimizedImage.downsize` with five arguments, so every emoji resize job now raises `ArgumentError`. Remove the duplicate and update the `Jobs::ResizeEmoji` call to pass "100x100", or keep one method that accepts both forms.

highbugapp/assets/javascripts/discourse/lib/utilities.js:182

Hard-coded 10MB upload limit overrides max_attachment_size_kb for attachments — The hard-coded 10MB limit ignores `max_attachment_size_kb`, so the browser blocks valid attachments above 10MB and lets oversized ones through below it. Apply the 10MB cap only when `type === 'image'`, keep the site setting for attachments, and fix the 413 handler the same way.

mediumbugapp/controllers/uploads_controller.rb:64-70

Image downsize loop ignores failures and passes a percentage to gifsicle — With `allow_animation: true`, GIFs go to `gifsicle --resize-fit 80%`, which expects WxH, so the command likely fails. `OptimizedImage.downsize` then returns false, the loop ignores it, and oversized GIFs are never shrunk after 5 wasted attempts.

Gold bugs found (3)

highdownsize is defined twice in OptimizedImage; the new (from, to, dimensions, opts) version overrides the (max_width, max_height) one, so existing callers such as ResizeEmoji that pass width and height now raise ArgumentError.
highThe client-side upload size check hardcodes 10 MB instead of the per-type max_<type>_size_kb setting, so attachment limits diverge from the server: larger allowed attachments are blocked and smaller limits are only enforced server-side.
highThe upload downsizing passes a percentage ('80%') as dimensions, but for animated GIFs the gifsicle path uses --resize-fit, which expects WxH geometry, so downsizing silently fails.

Gold bugs missed (5)

mediumAuto-downsizing passes the upload tempfile path, which lacks a .gif extension, so the animated branch is never chosen and convert keeps only the first frame, flattening oversized animated GIFs.
highClaims the downsize loop checking tempfile.size may never terminate because of a stale cached size, causing infinite loops.
highOversized SVG uploads go through the new ImageMagick downsize loop because SVG counts as an image, so the vector file is rasterized or corrupted in place before Upload.create_for parses it as SVG.
criticalThe upload tempfile path, which for API URL uploads embeds the request-controlled type param, is now passed to OptimizedImage.downsize and run unescaped in a shell via backticks, allowing command injection through type.
mediumThe 413 upload error message states a hard-coded 10 MB maximum that may not match the limit the server or web server actually enforces.