Claude Sonnet 5.5 · Heavy

feature-automatically-downsize-large-images-discourse-cursor

Discourse · Ruby · S · 30–99 lines · 3 files

The generalist plus 9 specialist lens agents in parallel, then the same verify and dedup steps. Judge: Claude Haiku 5.5.

Gold bugs found
3 of 8
Comments published
3
Comments matching a bug
3
Comments not matching
0
Cost of this PR
$0.957

Published comments (3)

highbugapp/models/optimized_image.rb:145-151

Duplicate downsize definition overrides first and breaks 5-argument callers — The second `downsize` definition replaces the first, so the existing 5-argument caller in `resize_emoji.rb` raises `ArgumentError`. Keep a single `downsize` that accepts both forms, or update that caller to pass "100x100".

mediumbugapp/controllers/uploads_controller.rb:64-70

Percentage resize with allow_animation fails for GIFs so downsizing loop never shrinks — gifsicle rejects a percentage resize, so `downsize` returns false and `tempfile` never shrinks across all 5 attempts, leaving oversized animated GIFs untouched. Pass `allow_animation: false` here and break out of the loop when `downsize` returns false.

mediumbugapp/assets/javascripts/discourse/lib/utilities.js:182

Client-side upload size check ignores max_attachment_size_kb setting — The hardcoded 10MB limit skips the per-type `max_attachment_size_kb` setting, so oversized attachments pass the client check and only fail after upload. Use the site setting for non-image types and apply the 10MB cap only when `type` is an image.

Gold bugs found (3)

highdownsize is defined twice in OptimizedImage; the new (from, to, dimensions, opts) version overrides the (max_width, max_height) one, so existing callers such as ResizeEmoji that pass width and height now raise ArgumentError.
highThe client-side upload size check hardcodes 10 MB instead of the per-type max_<type>_size_kb setting, so attachment limits diverge from the server: larger allowed attachments are blocked and smaller limits are only enforced server-side.
highThe upload downsizing passes a percentage ('80%') as dimensions, but for animated GIFs the gifsicle path uses --resize-fit, which expects WxH geometry, so downsizing silently fails.

Gold bugs missed (5)

mediumAuto-downsizing passes the upload tempfile path, which lacks a .gif extension, so the animated branch is never chosen and convert keeps only the first frame, flattening oversized animated GIFs.
highClaims the downsize loop checking tempfile.size may never terminate because of a stale cached size, causing infinite loops.
highOversized SVG uploads go through the new ImageMagick downsize loop because SVG counts as an image, so the vector file is rasterized or corrupted in place before Upload.create_for parses it as SVG.
criticalThe upload tempfile path, which for API URL uploads embeds the request-controlled type param, is now passed to OptimizedImage.downsize and run unescaped in a shell via backticks, allowing command injection through type.
mediumThe 413 upload error message states a hard-coded 10 MB maximum that may not match the limit the server or web server actually enforces.