Kimi K3.1 Pro · Balanced
feat-convert-insightsbookingservice-to-use-prisma-sql-raw-queries-cal-com
cal.com · TypeScript · M · 100–299 lines · 1 files
The normal review, with one generalist agent. Judge: Claude Haiku 5.5.
- Gold bugs found
- 1 of 3
- Comments published
- 1
- Comments matching a bug
- 1
- Comments not matching
- 0
- Cost of this PR
- $0.398
Published comments (1)
mediumbugpackages/lib/server/service/insightsBooking.ts:74-75
Unparenthesized authorization OR lets team bookings escape date filters — Out-of-range team bookings can be returned because appended `AND` predicates, such as a date range, apply only to the user branch under SQL precedence. Wrap `authConditions` in an outer pair of parentheses before returning it.
Gold bugs found (1)
highClaims getBaseConditions returns OR fragments without parentheses, so a caller appending `AND <extra>` would leak rows outside the authorization scope.
Gold bugs missed (2)
mediumThe getBaseConditions test uses a single booking matching both auth and filter conditions, so it would pass even if the conditions were not combined.
mediumThe new public options type makes teamId optional for team scope, so a missing teamId compiles and silently yields empty insights instead of a type error.