Kimi K3.1 Pro · Heavy
feat-convert-insightsbookingservice-to-use-prisma-sql-raw-queries-cal-com
cal.com · TypeScript · M · 100–299 lines · 1 files
The generalist plus 9 specialist lens agents in parallel, then the same verify and dedup steps. Judge: Claude Haiku 5.5.
- Gold bugs found
- 0 of 3
- Comments published
- 1
- Comments matching a bug
- 0
- Comments not matching
- 1
- Cost of this PR
- $0.892
Published comments (1)
mediumbugpackages/lib/server/service/__tests__/insightsBooking.integration-test.ts:295-299
Flat Prisma.Sql expectations fail against nested SQL fragments — `toEqual` compares the flat expectation's `strings` and `values` with the service's nested fragments, so equivalent rendered SQL still fails. Build the expectation with matching `Prisma.Sql` nesting or compare rendered SQL and parameters, including the org-scope and combined `eventType`/`memberUser` filter assertions.
Gold bugs found (0)
None.
Gold bugs missed (3)
mediumThe getBaseConditions test uses a single booking matching both auth and filter conditions, so it would pass even if the conditions were not combined.
mediumThe new public options type makes teamId optional for team scope, so a missing teamId compiles and silently yields empty insights instead of a type error.
highClaims getBaseConditions returns OR fragments without parentheses, so a caller appending `AND <extra>` would leak rows outside the authorization scope.